sanj/padmaEmbeds
1
0
Fork 0
Code Issues 4 Pull requests 1 Releases Wiki Activity

Implements a Slide class #6

Merged
j merged 2 commits from refactor-class into master 2018-03-17 09:45:19 +00:00
Conversation 1 Commits 2 Files changed 1 +168 -148
sanj commented 2018-03-17 09:15:32 +00:00
Owner
Copy link

Refactors to use a Slide class with methods encapsulated.

This would be a first step toward more cleanups and perhaps more features.

This part seems to work the same as before the refactor, so I'd like to merge this in and then think about further improvements.

cc @j - would be great to get quick feedback / thumbs up :-)

Refactors to use a Slide class with methods encapsulated. This would be a first step toward more cleanups and perhaps more features. This part seems to work the same as before the refactor, so I'd like to merge this in and then think about further improvements. cc @j - would be great to get quick feedback / thumbs up :-)
j commented 2018-03-17 09:42:03 +00:00
Owner
Copy link

is slideData still needed?

is slideData still needed?
j closed this pull request 2018-03-17 09:45:19 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: sanj/padmaEmbeds#6
No description provided.
Delete branch "refactor-class"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?