sanj/padmaEmbeds
1
0
Fork 0
Code Issues4 Pull requests1 Releases Wiki Activity

Global pause / resume #12

Open
sanj wants to merge 1 commit from global-pause into master
Conversation 0 Commits 1 Files changed 2 +117 -5
sanj commented 2018-04-25 11:53:32 +00:00
Owner

First stab at this --

It seems to mostly work. Right now, one can hit "space" to trigger pause and resume. Should probably think of some UI, also to indicate whether it is currently paused or not.

Some of the logic, especially for resetting time-outs for the zooms seems a bit fragile and could use some testing.

Things done:

  • Added an "overlay" div so the iframes themselves are no longer interactable with. Hopefully we don't need this as you can play and pause from the outside.
  • Added global pause / resume / toggle methods and corresponding methods on the Slide class
  • Added keydown handler to trigger togglePause on pressing the spacebar

@j - this seemed more straightforward than something which is checking state every frame, etc. - this approach seems to work, though some math maybe off - let me know if there's any feedback, thanks :-)

First stab at this -- It seems to mostly work. Right now, one can hit "space" to trigger pause and resume. Should probably think of some UI, also to indicate whether it is currently paused or not. Some of the logic, especially for resetting time-outs for the zooms seems a bit fragile and could use some testing. Things done: - Added an "overlay" div so the iframes themselves are no longer interactable with. Hopefully we don't need this as you can play and pause from the outside. - Added global pause / resume / toggle methods and corresponding methods on the Slide class - Added keydown handler to trigger togglePause on pressing the spacebar @j - this seemed more straightforward than something which is checking state every frame, etc. - this approach seems to work, though some math maybe off - let me know if there's any feedback, thanks :-)
This pull request can be merged automatically.
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin global-pause:global-pause
git checkout global-pause

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git checkout master
git merge --no-ff global-pause
git checkout global-pause
git rebase master
git checkout master
git merge --ff-only global-pause
git checkout global-pause
git rebase master
git checkout master
git merge --no-ff global-pause
git checkout master
git merge --squash global-pause
git checkout master
git merge --ff-only global-pause
git checkout master
git merge global-pause
git push origin master
Sign in to join this conversation.
No reviewers
No labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: sanj/padmaEmbeds#12
No description provided.
Delete branch "global-pause"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?