Static pages #1

Merged

Ghost merged 3 commits from create-the-static-pages into master

2018-12-05 18:54:07 +00:00

sanj commented

2018-12-05 09:13:11 +00:00

Owner

@ahmedayman055 just opening this as a PR for it to be a bit easier to compare changes, etc.

sanj commented

2018-12-05 09:20:22 +00:00

Author

Owner

@ahmedayman055 this looks perfect!

My only minor nitpick / feedback would be to name the folder with the components as just "components" and not "subComponents" but this is really not a big deal. Just since we have a separate folder for "containers", the "components" folder is anyways like "sub" components. We can always further create folders inside the "components" folder if we feel we need to split up the components further.

Overall though this looks absolutely perfect and really like the way you've split up the various components!

Feel free to merge this whenever, even in an incomplete state. After we have some basic things working, we'll move to a more "git flow" like branching model and create a "develop" branch, etc. - right now don't wait too long before merging in :-)

@ahmedayman055 this looks perfect! My only minor nitpick / feedback would be to name the folder with the components as just "components" and not "subComponents" but this is really not a big deal. Just since we have a separate folder for "containers", the "components" folder is anyways like "sub" components. We can always further create folders inside the "components" folder if we feel we need to split up the components further. Overall though this looks absolutely perfect and really like the way you've split up the various components! Feel free to merge this whenever, even in an incomplete state. After we have some basic things working, we'll move to a more "git flow" like branching model and create a "develop" branch, etc. - right now don't wait too long before merging in :-)