CAMP/camp
1
0
Fork 0
Code Issues 3 Pull Requests Releases Wiki Activity

Make images ImageFields and not strings with some magic #3

New Issue
Open
opened 2018-01-02 11:11:42 +00:00 by sanj · 2 comments
sanj commented 2018-01-02 11:11:42 +00:00
Owner
Copy Link
No description provided.
sanj commented 2018-01-03 10:57:58 +00:00
Author
Owner
Copy Link

The image field for Content here is defined as a CharField: https://code.with.camp/CAMP/camp/src/master/content/models.py#L79

This should be changed to an ImageField and data migrations performed appropriately.

Are there other instances where image fields have the wrong type defined in the models?

The image field for Content here is defined as a CharField: https://code.with.camp/CAMP/camp/src/master/content/models.py#L79 This should be changed to an ImageField and data migrations performed appropriately. Are there other instances where image fields have the wrong type defined in the models?
j commented 2018-01-03 16:57:17 +00:00
Owner
Copy Link

think its only that one case, all access to the field should already go via image_url https://code.with.camp/CAMP/camp/src/master/content/models.py#L124

think its only that one case, all access to the field should already go via image_url https://code.with.camp/CAMP/camp/src/master/content/models.py#L124
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: CAMP/camp#3
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?