858/frontend
1
0
Fork 0
Code Issues 11 Pull Requests Releases Wiki Activity

fix bug on random topic not loading on first page load

Browse Source
This commit is contained in:
Sanjay Bhangar 2018-12-07 19:25:43 +02:00
parent 7d48fad50a
commit c9d1495c43
1 changed files with 3 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/containers/Home.js
View File

@ -18,10 +18,9 @@ class Home extends React.Component {
} }
componentWillReceiveProps(nextProps) { componentWillReceiveProps(nextProps) {
//FIXME: this is quite ugly // This is slightly awkward - we need to check that we have all topics,
// We are trying to figure out if allTopics is loaded but no request made for random topic yet, // But don't have a random topic yet (or at not already loading a random topic)
// and then we want to load the random topic. But there should be a cleaner way to do this. if (this.props.allTopics && !(this.props.loadingRandomTopic || nextProps.loadingRandomTopic) && !this.props.randomTopic) {
if (!nextProps.loadingAllTopics && !this.props.randomTopic && (!this.props.loadingRandomTopic || nextProps.loadingRandomTopic)) {
this.props.getRandomTopicVideos(this.props.allTopics); this.props.getRandomTopicVideos(this.props.allTopics);
} }
} }